Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added filter_policy and filter_policy_scope functionality to subscribers #87

Merged
merged 4 commits into from
Oct 9, 2024
Merged

Added filter_policy and filter_policy_scope functionality to subscribers #87

merged 4 commits into from
Oct 9, 2024

Conversation

vladget
Copy link
Contributor

@vladget vladget commented Oct 9, 2024 •
edited
Loading

what

  • Added filter_policy and filter_policy_scope functionality to subscribers
  • Made some properties of subscribers variable optional with defaults values
  • Bumped terraform version to >= 1.3.0

why

  • It will be great to have this functionality as feature request already there.

references

@vladget vladget requested review from a team as code owners October 9, 2024 11:54
@vladget vladget requested review from hans-d and RoseSecurity October 9, 2024 11:54
@mergify mergify bot added the triage Needs triage label Oct 9, 2024
@goruha
Copy link
Member

goruha commented Oct 9, 2024

/terratest

@goruha
Copy link
Member

goruha commented Oct 9, 2024

@vladget, thanks for your contribution.

https://github.com/cloudposse/terraform-aws-sns-topic/actions/runs/11254407141/job/31303864309?pr=87

https://github.com/cloudposse/terraform-aws-sns-topic/actions/runs/11254407141/job/31303864676?pr=87

goruha
goruha requested changes Oct 9, 2024
View reviewed changes
Copy link
Member

@goruha goruha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments

@vladget vladget requested a review from goruha October 9, 2024 15:30
@vladget
Copy link
Contributor Author

vladget commented Oct 9, 2024

/terratest

@goruha
Copy link
Member

goruha commented Oct 9, 2024

/terratest

@goruha
Copy link
Member

goruha commented Oct 9, 2024

/terratest

@goruha goruha added the major Breaking changes (or first stable release) label Oct 9, 2024
@mergify mergify bot removed the triage Needs triage label Oct 9, 2024
@goruha goruha merged commit 50da41d into cloudposse:main Oct 9, 2024
35 checks passed
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 9, 2024

These changes were released in v1.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goruha goruha goruha approved these changes

@hans-d hans-d Awaiting requested review from hans-d hans-d is a code owner automatically assigned from cloudposse/contributors

@RoseSecurity RoseSecurity Awaiting requested review from RoseSecurity RoseSecurity is a code owner automatically assigned from cloudposse/contributors

Assignees
No one assigned
Labels
major Breaking changes (or first stable release)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vladget @goruha